Ticket #45 (closed defect: fixed)

Opened 3 years ago

Last modified 10 months ago

Support libusb_get_device_speed() on OpenBSD

Reported by: trygvis Owned by: mpi
Milestone: Component: libusb-1.0 OpenBSD backend
Keywords: Cc:
Blocked By: Blocks:

Description

Ref ​http://thread.gmane.org/gmane.comp.lib.libusb.devel.general/10863

Change History

comment:1 Changed 18 months ago by Hans de Goede <hdegoede@…>

In [c8c40bcbd22abca922ff31c4ed6a75fd7af78b59/libusb]:

Add new API function libusb_get_device_speed()

Reworked version of my earlier patch, largely modelled after (if not
copy and pasted from) Trygve Laugstøl's <trygvis@…> similar
commit 5a6541e0d80fb1f21e2b960bc2337a612f9d74fb in
​git://git.libusb.org/libusb-trygvis.git
​http://git.libusb.org/libusb-trygvis.git
​http://git.libusb.org/?p=libusb-trygvis.git;a=commitdiff;h=5a6541e0d

This patch does not add any OS specific code. The supporting code in
each backend follows in separate patches. References #45.

Signed-off-By: Hans de Goede <hdegoede@…>

comment:2 Changed 18 months ago by Hans de Goede <hdegoede@…>

In [44d6319f57e7e2c77347da228ed032e62716b438/libusb]:

Linux: Provide libusb_get_device_speed() data from sysfs

References #45.

Signed-off-by: Hans de Goede <hdegoede@…>

comment:3 Changed 18 months ago by trygvis

In [382b7deaadd7e2f1d08c9e921e460bb3abf130b2/libusb]:

Darwin: Provide libusb_get_device_speed() data

References #45.

comment:4 Changed 18 months ago by pbatard

  • Owner set to pbatard
  • Resolution set to fixed
  • Status changed from new to closed

In [0288bf24f91eca9f433ebad91a7eb6c0e3e29133/libusb]:

Windows: Provide libusb_get_device_speed() data

  • use (currently superspeed unaware) USB_NODE_CONNECTION_INFORMATION_EX

Fixes #45.

[stuge: Explicitly convert OS device speeds to libusb device speeds]
[pbatard: Add breaks overlooked when adding explicit conversion]

comment:5 Changed 14 months ago by xiaofan

  • Resolution fixed deleted
  • Status changed from closed to reopened

I will reopen this ticket since the current OpenBSD implementation does not support this.

comment:6 Changed 13 months ago by stuge

  • Keywords openbsd added
  • Owner changed from pbatard to mpi
  • Status changed from reopened to assigned
  • Summary changed from Make negotiated speed available to Support libusb_get_device_speed() on OpenBSD
  • Type changed from enhancement to defect

comment:7 Changed 13 months ago by stuge

  • Component changed from libusb-1.0 to libusb-1.0 OpenBSD backend

comment:8 Changed 13 months ago by stuge

  • Keywords openbsd removed

comment:9 Changed 13 months ago by xiaofan

  • Resolution set to fixed
  • Status changed from assigned to closed

Resolved by commit 84d5eafd1f24a1c6f77f0c2a2ad40e1fbfdea381
and released in 1.0.9.

comment:10 Changed 10 months ago by stuge

  • Resolution set to fixed
  • Status changed from assigned to closed

In 84d5eafd1f24a1c6f77f0c2a2ad40e1fbfdea381/libusb:

OpenBSD: Provide libusb_get_device_speed() data

Because the different speed values used by the libusb and OpenBSD's
usb_device_info structure are compatible, keep the code simple and
just copy the value returned by the USB_GET_DEVICEINFO ioctl() call.

Fixes #45.

Note: See TracTickets for help on using tickets.