Ticket #74 (closed enhancement: fixed)

Opened 3 years ago

Last modified 18 months ago

[PATCH] Do not include useless pthread.h

Reported by: ludovicrousseau Owned by: Ludovic Rousseau <rousseau@…>
Milestone: Component: libusb-1.0
Keywords: Cc:
Blocked By: Blocks:

Description

The code do not use threads so no need to #include <pthread.h>

Attachments

0001-Do-not-include-useless-pthread.h.patch​ (684 bytes) - added by ludovicrousseau 3 years ago.

Download all attachments as: .zip

Change History

Changed 3 years ago by ludovicrousseau

comment:1 Changed 3 years ago by ludovicrousseau

This is a new iteration of ticket #71: Remove useless #include

comment:2 Changed 3 years ago by segher

This looks okay. Did you check that the resulting binary is
identical?

comment:3 Changed 3 years ago by ludovicrousseau

No. I did not checked the resulting binary is identical.

comment:4 Changed 2 years ago by ludovicrousseau

I compared the resulting binaries. They are different.

I also compared the .S source files (generated using make CC="gcc -E") and they are identical except for the included headers.

comment:5 Changed 21 months ago by Ludovic Rousseau <rousseau@…>

In [77f501d9176ae7ef2a29f8196a6a0fcdfba4c6b3/libusb-pbatard]:

Do not include useless pthread.h

The code does not use threads so no need to #include <pthread.h>
Fixes #74.

comment:6 Changed 18 months ago by Ludovic Rousseau <rousseau@…>

  • Owner set to Ludovic Rousseau <rousseau@…>
  • Resolution set to fixed
  • Status changed from new to closed

In [c569e5b3b314538f45d0b3b6f14ce3dbdfee1be9/libusb]:

Linux: Do not include useless pthread.h

The code does not use threads so no need to #include <pthread.h>
Fixes #74.

Note: See TracTickets for help on using tickets.